2
0

2 Commits

Author SHA1 Message Date
4eb7f78b6b fix(mcp): restore Content-Length framing for MCP stdio
All checks were successful
Release / build (amd64, windows) (push) Successful in 39s
Release / build (arm64, darwin) (push) Successful in 40s
Release / build (amd64, linux) (push) Successful in 52s
Release / build (amd64, darwin) (push) Successful in 1m27s
Release / build (arm64, linux) (push) Successful in 1m38s
Release / release (push) Successful in 24s
Revert to LSP-style Content-Length framing for MCP stdio transport. Testing confirmed that MCP clients (Claude Code) do expect Content-Length headers, not raw NDJSON. The earlier NDJSON change was based on incorrect assumption about the protocol.
2026-04-15 03:46:17 -04:00
c6ed87cdcf fix(mcp): suppress responses to JSON-RPC notifications
All checks were successful
Release / build (amd64, windows) (push) Successful in 39s
Release / build (amd64, linux) (push) Successful in 57s
Release / build (arm64, linux) (push) Successful in 1m4s
Release / build (amd64, darwin) (push) Successful in 1m20s
Release / build (arm64, darwin) (push) Successful in 1m21s
Release / release (push) Successful in 22s
Add JSON-RPC notification detection and response suppression per MCP spec. Notifications (requests without "id" field) must never receive responses, even if the upstream server returns an error. Prevents handshake failures when Claude Code sends notifications/initialized and receives unexpected error responses.

Changes:
- Add isJsonRpcNotification() to detect requests without "id" field
- Skip error responses for notifications
- Suppress upstream responses to notifications
- Add detailed comments explaining JSON-RPC 2.0 notification semantics
2026-04-15 02:27:22 -04:00

38
main.go
View File

@@ -90,10 +90,22 @@ func main() {
debugLog("Received: %s", string(line)) debugLog("Received: %s", string(line))
// JSON-RPC notifications (no "id" field) must NEVER receive a response.
// The MCP spec defines notifications/initialized, notifications/cancelled,
// notifications/progress, etc. — these are fire-and-forget. Even if the
// remote gitcaddy server returns an error for an unknown notification, we
// must suppress it on the way back to the client (Claude Code), otherwise
// the client sees an unexpected response and fails the handshake.
isNotification := isJsonRpcNotification(line)
// Forward to Gitea's MCP endpoint // Forward to Gitea's MCP endpoint
response, err := forwardToGitea(line) response, err := forwardToGitea(line)
if err != nil { if err != nil {
debugLog("Forward error: %v", err) debugLog("Forward error: %v", err)
if isNotification {
// Notification — no response allowed, just swallow.
continue
}
// Send error response // Send error response
errorResp := map[string]interface{}{ errorResp := map[string]interface{}{
"jsonrpc": "2.0", "jsonrpc": "2.0",
@@ -110,11 +122,30 @@ func main() {
debugLog("Response: %s", string(response)) debugLog("Response: %s", string(response))
// Write response to stdout with Content-Length framing if isNotification {
// Notification — never respond, even if the remote sent something.
debugLog("Suppressing response to notification")
continue
}
// Write response to stdout as newline-delimited JSON
writeFramed(response) writeFramed(response)
} }
} }
// isJsonRpcNotification reports whether a raw JSON-RPC message is a notification
// (a request without an "id" field). Per JSON-RPC 2.0, servers MUST NOT reply to
// notifications.
func isJsonRpcNotification(raw []byte) bool {
var probe map[string]json.RawMessage
if err := json.Unmarshal(raw, &probe); err != nil {
return false
}
_, hasId := probe["id"]
_, hasMethod := probe["method"]
return hasMethod && !hasId
}
func forwardToGitea(request []byte) ([]byte, error) { func forwardToGitea(request []byte) ([]byte, error) {
mcpURL := giteaURL + "/api/v2/mcp" mcpURL := giteaURL + "/api/v2/mcp"
@@ -215,10 +246,7 @@ func writeResponse(resp interface{}) {
} }
func writeFramed(data []byte) { func writeFramed(data []byte) {
// MCP stdio transport uses newline-delimited JSON (NDJSON), not LSP-style fmt.Fprintf(os.Stdout, "Content-Length: %d\r\n\r\n%s", len(data), data)
// Content-Length framing. Claude Code and other MCP clients reject
// Content-Length headers on stdio, so we emit one JSON object per line.
fmt.Fprintf(os.Stdout, "%s\n", data)
} }
func debugLog(format string, args ...interface{}) { func debugLog(format string, args ...interface{}) {