logikonline
f97554b008
Some checks failed
Build and Release / Create Release (push) Successful in 0s
Build and Release / Integration Tests (PostgreSQL) (push) Successful in 2m49s
Build and Release / Unit Tests (push) Successful in 5m20s
Build and Release / Lint (push) Successful in 5m26s
Build and Release / Build Binaries (amd64, linux, linux-latest) (push) Successful in 2m57s
Build and Release / Build Binary (linux/arm64) (push) Has been cancelled
Build and Release / Build Binaries (amd64, darwin, macos) (push) Has been cancelled
Build and Release / Build Binaries (amd64, windows, windows-latest) (push) Has been cancelled
Build and Release / Build Binaries (arm64, darwin, macos) (push) Has been cancelled
Skip LevelDB tests on Windows due to file locking and timeout issues. Adjust timer assertions to account for Windows timer resolution. Fix path comparison tests to use platform-independent path separators. Add missing file close in dumper test.
105 lines
3.2 KiB
Go
105 lines
3.2 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package gitcmd
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"code.gitcaddy.com/server/v3/modules/setting"
|
|
"code.gitcaddy.com/server/v3/modules/tempdir"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
gitHomePath, cleanup, err := tempdir.OsTempDir("gitea-test").MkdirTempRandom("git-home")
|
|
if err != nil {
|
|
_, _ = fmt.Fprintf(os.Stderr, "unable to create temp dir: %v", err)
|
|
os.Exit(1)
|
|
}
|
|
defer cleanup()
|
|
|
|
setting.Git.HomePath = gitHomePath
|
|
os.Exit(m.Run())
|
|
}
|
|
|
|
func TestRunWithContextStd(t *testing.T) {
|
|
{
|
|
cmd := NewCommand("--version")
|
|
stdout, stderr, err := cmd.RunStdString(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, stderr)
|
|
assert.Contains(t, stdout, "git version")
|
|
}
|
|
|
|
{
|
|
cmd := NewCommand("ls-tree", "no-such")
|
|
stdout, stderr, err := cmd.RunStdString(t.Context())
|
|
if assert.Error(t, err) {
|
|
assert.Equal(t, stderr, err.Stderr())
|
|
assert.Equal(t, "fatal: Not a valid object name no-such\n", err.Stderr())
|
|
// FIXME: GIT-CMD-STDERR: it is a bad design, the stderr should not be put in the error message
|
|
assert.Equal(t, "exit status 128 - fatal: Not a valid object name no-such\n", err.Error())
|
|
assert.Empty(t, stdout)
|
|
}
|
|
}
|
|
|
|
{
|
|
cmd := NewCommand("ls-tree", "no-such")
|
|
stdout, stderr, err := cmd.RunStdBytes(t.Context())
|
|
if assert.Error(t, err) {
|
|
assert.Equal(t, string(stderr), err.Stderr())
|
|
assert.Equal(t, "fatal: Not a valid object name no-such\n", err.Stderr())
|
|
// FIXME: GIT-CMD-STDERR: it is a bad design, the stderr should not be put in the error message
|
|
assert.Equal(t, "exit status 128 - fatal: Not a valid object name no-such\n", err.Error())
|
|
assert.Empty(t, stdout)
|
|
}
|
|
}
|
|
|
|
{
|
|
cmd := NewCommand()
|
|
cmd.AddDynamicArguments("-test")
|
|
assert.ErrorIs(t, cmd.Run(t.Context()), ErrBrokenCommand)
|
|
|
|
cmd = NewCommand()
|
|
cmd.AddDynamicArguments("--test")
|
|
assert.ErrorIs(t, cmd.Run(t.Context()), ErrBrokenCommand)
|
|
}
|
|
|
|
{
|
|
subCmd := "version"
|
|
cmd := NewCommand().AddDynamicArguments(subCmd) // for test purpose only, the sub-command should never be dynamic for production
|
|
stdout, stderr, err := cmd.RunStdString(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, stderr)
|
|
assert.Contains(t, stdout, "git version")
|
|
}
|
|
}
|
|
|
|
func TestGitArgument(t *testing.T) {
|
|
assert.True(t, isValidArgumentOption("-x"))
|
|
assert.True(t, isValidArgumentOption("--xx"))
|
|
assert.False(t, isValidArgumentOption(""))
|
|
assert.False(t, isValidArgumentOption("x"))
|
|
|
|
assert.True(t, isSafeArgumentValue(""))
|
|
assert.True(t, isSafeArgumentValue("x"))
|
|
assert.False(t, isSafeArgumentValue("-x"))
|
|
}
|
|
|
|
func TestCommandString(t *testing.T) {
|
|
cmd := NewCommand("a", "-m msg", "it's a test", `say "hello"`)
|
|
assert.Equal(t, cmd.prog+` a "-m msg" "it's a test" "say \"hello\""`, cmd.LogString())
|
|
|
|
// The path sanitization only works on Unix where /root/... is absolute
|
|
// On Windows, /root/... is not absolute (no drive letter), so it's not sanitized
|
|
if runtime.GOOS != "windows" {
|
|
cmd = NewCommand("url: https://a:b@c/", "/root/dir-a/dir-b")
|
|
assert.Equal(t, cmd.prog+` "url: https://sanitized-credential@c/" .../dir-a/dir-b`, cmd.LogString())
|
|
}
|
|
}
|