Lauris BH
801cb3b447
Add restricted user filter to LDAP authentication ( #10600 )
...
* Add restricted user filter to LDAP authentification
* Fix unit test cases
2020-03-05 08:30:33 +02:00
Antoine GIRARD
e975b73b30
Ensure executable bit is kept on the web editor ( #10607 )
...
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-03-05 00:46:12 +01:00
Lauris BH
490633b0c4
OAuth2: add Yandex provider ( #8335 ) ( #10564 )
...
* OAuth2: add Yandex provider (#8335 )
* remove changes from locale ru-RU
* fmt modules/auth/oauth2/oauth2.go
Co-Authored-By: 6543 <6543@obermui.de >
* fix fmt
* Update templates/admin/auth/new.tmpl
* fix fmt
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-03-05 00:08:52 +02:00
zeripath
e573ec2190
Fix LFS max file size enforcement ( #10593 )
...
Unfortunately the batch handler also needs to enforce max file size.
Enforce max file size in batch handler
2020-03-03 14:57:27 -06:00
techknowlogick
20a441b19c
nextcloud oauth ( #10562 )
...
Fix #7078
2020-03-02 22:11:45 -05:00
zeripath
435210acba
Change default value of DefaultCommandExecutionTimeout to match cheatsheet ( #10581 )
2020-03-02 22:13:01 -03:00
Lunny Xiao
60cb813692
Display pull request head branch even the branch deleted or repository deleted ( #10413 )
...
* Display pull request head branch even the branch deleted or repository deleted
* Merge getHeadRepo/loadHeadRepo and getBaseRepo/loadBaseRepo on pull and fill repo when pr.Issue.Repo is available
* retrieve sha from pull head when pull request branch deleted and fix tests
* Fix test
* Ensure MustHeadRepoName returns empty string if no head repo
Co-authored-by: zeripath <art27@cantab.net >
2020-03-02 22:31:55 +00:00
6543
bb2cea62d3
Remove Unused Functions ( #10516 )
...
* remove ReplaceLeft
* remove GetRepositoryByOwnerAndName chainload to models.GetRepositoryByOwnerAndName
* remove CheckUnitUser chainload to models.CheckUnitUser
* remove MakeAssigneeList
* remove DownloadDiff & DownloadPatch -> DownloadDiffOrPatch
* remove GetRandomBytesAsBase64
* remove PushUpdateDeleteTags
* remove GetUserByKeyID
(you still can resolve user by "k, err := GetPublicKeyByID; userID := k.OwnerID")
* remove BasicAuthEncode from struct package -> same function in modules/base/tools !
* remove UserID from api.utils
* remove unused func from structs package
2020-03-02 00:05:44 +02:00
Gustavo Marin
91edea0016
adds API endpoints to manage OAuth2 Application (list/create/delete) ( #10437 )
...
* add API endpoint to create OAuth2 Application.
* move endpoint to /user. Add swagger documentations and proper response type.
* change json tags to snake_case. add CreateOAuth2ApplicationOptions to swagger docs.
* change response status to Created (201)
* add methods to list OAuth2 apps and delete an existing OAuth2 app by ID.
* add APIFormat convert method and file header
* fixed header
* hide secret on oauth2 application list
* add Created time to API response
* add API integration tests for create/list/delete OAuth2 applications.
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-29 03:19:32 -03:00
6543
f75f9e9edf
[Refactor] move APIFormat() of Issue and Label to convert package ( #10423 )
...
* Label: delete .APIFormat() and use convert.ToLabel()
* move issue APIFormat too
* add missing one
* move TEST too
* handle error -> return empty APIIssue
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-28 23:49:50 -03:00
zeripath
f42c4719de
Handle panic in indexer initialisation better ( #10534 )
...
* Handle panic in indexer initialisation better
* as per @guillep2k
2020-02-28 22:00:09 +00:00
zeripath
85fb582f6a
Relax sanitization as per https://github.com/jch/html-pipeline ( #10527 )
...
Looking at github/markup#245 it is clear that GH uses https://github.com/jch/html-pipeline to sanitize. This PR relaxes our sanitization to more closely match this.
Fixes #10471
and likely others...
2020-02-28 20:05:12 +00:00
6543
45da3498dc
inform participants on UI too ( #10473 )
...
* inform participants on UI too
* ajust test
* refactor getParticipantIDsByIssue
2020-02-28 05:16:41 -03:00
zeripath
e10c2c7695
Add max-file-size to LFS ( #10463 )
...
* Add max-file-size to LFS
* Update modules/lfs/server.go
* As per @silverwind
Co-Authored-By: silverwind <me@silverwind.io >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-28 01:46:57 -03:00
zeripath
3604f1431b
Use media links for img in post-process ( #10515 )
...
* use media links for img in post-process
* do not visit text of anchors
2020-02-28 01:16:05 -03:00
6543
1baa253947
Fix potential bugs ( #10513 )
...
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
2020-02-27 20:10:27 -03:00
guillep2k
ad609fcc03
Fix SQLite concurrency problems by using BEGIN IMMEDIATE ( #10368 )
...
* Test locking immediate for SQLite3
* fix url field separator
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: zeripath <art27@cantab.net >
2020-02-27 07:51:37 +08:00
6543
d73845d0cf
Code Refactor of IssueWatch related things ( #10401 )
...
* refactor
* optimize
* remove Iretating function
LoadWatchUsers do not load Users into IW object and it is used only in api ... so move this logic
* remove unessesary
* Apply suggestions from code review
Thx
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* make Tests more robust
* fix rebase
* restart CI
* CI no dont hit sqlites deadlock
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-26 03:32:22 -03:00
John Olheiser
1116bd4bf7
Change admin dashboard to POST ( #10465 )
...
* Add form and convert to POST
* Redirect for flash
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-25 16:54:13 -06:00
6543
09f8a5ce95
[API] enable paggination for ListRepoTags ( #10454 )
...
* enable paggination for repoTags
* precalculate first, cut slice second
* Apply suggestions from code review
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-25 14:07:07 -05:00
guillep2k
39e5abb2f7
Various fixes in login sources ( #10428 )
2020-02-23 13:52:05 -06:00
Lunny Xiao
df21ed6066
Fix webhook bug ( #10427 )
...
Co-authored-by: techknowlogick <matti@mdranta.net >
2020-02-23 13:49:40 -05:00
zeripath
53151fede2
Handle push rejection message in Merge & Web Editor ( #10373 )
...
* Handle push rejection message in Merge
* placate golangci-lint
* Fix sanitize, adjust message handling
* oops
* Oops
* Handle push-rejection in webeditor CRUD too
* Apply suggestions from code review
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-02-22 15:08:48 +02:00
zeripath
95f8737ca2
Render READMEs in docs/ .gitea or .github from root ( #10361 )
...
* Render READMEs in docs/ .gitea or .github from root
2020-02-21 17:04:20 -06:00
Lauris BH
1e785f357f
Add detected file language to code search ( #10256 )
...
Move langauge detection to separate module to be more reusable
Add option to disable vendored file exclusion from file search
Allways show all language stats for search
2020-02-20 16:53:55 -03:00
Lunny Xiao
3b30c6ade0
Fix notification ( #10331 )
2020-02-18 10:52:57 +02:00
John Olheiser
0775a62a1d
Inject SVG sprite via ajax ( #10320 )
...
* AJAX SVG
* Fix PWA
* Remove unused PWA assets
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-Authored-by: silverwind <me@silverwind.io >
2020-02-17 23:11:59 +00:00
mrsdizzie
db1ed7b24c
Don't manually replace whitespace during render ( #10291 )
...
* Don't manually replace whitespace during render
For historical reasons Gitea manually alters the urlPrefix and replaces
a whitespace with a +. This Works for URLs, but we're also passing
urlPrefix to git calls and adding the + is breaking the tree path.
Goldmark will automatically convert a white space to the proper %20, so
we should leave the string as is which lets us pass it to git unmodified
and then let Goldmark fix it.
Also fixed separate bug in URLJoin I noticed while testing where it will
silently discard sections of a path that have # in them (possibly
others). We should just escape it first.
Fixes 10156
* Escape elems as well
* Revert "Escape elems as well"
This reverts commit 8bf49596fee6fac4d9da256cd1e90a0ec0183671.
* restart ci
* remove changes to URLJoin
* restart ci
Co-authored-by: techknowlogick <matti@mdranta.net >
2020-02-17 07:46:51 +02:00
zeripath
6298a97535
Notification: queue ui.go notification-service ( #10281 )
...
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-02-15 19:29:43 -05:00
zeripath
368acbc7ca
Fix Workerpool deadlock ( #10283 )
...
* Prevent deadlock on boost
* Force a boost in testchannelqueue
2020-02-15 18:44:58 +00:00
Lauris BH
21b291cf62
Index code and stats only for non-empty repositories ( #10251 )
...
Fix test and switch to unique queue
Fix MySQL support when deleting old statistics
2020-02-14 13:42:30 +01:00
Lunny Xiao
955915a31f
Issue search support elasticsearch ( #9428 )
...
* Issue search support elasticsearch
* Fix lint
* Add indexer name on app.ini
* add a warnning on SearchIssuesByKeyword
* improve code
2020-02-13 14:06:17 +08:00
David Svantesson
500dccd43a
Add API branch protection endpoint ( #9311 )
...
* add API branch protection endpoint
* lint
* Change to use team names instead of ids.
* Status codes.
* fix
* Fix
* Add new branch protection options (BlockOnRejectedReviews, DismissStaleApprovals, RequireSignedCommits)
* Do xorm query directly
* fix xorm GetUserNamesByIDs
* Add some tests
* Improved GetTeamNamesByID
* http status created for CreateBranchProtection
* Correct status code in integration test
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: zeripath <art27@cantab.net >
2020-02-12 23:19:35 +00:00
Lunny Xiao
f3a6f1fc1a
Fix queue pop error and stat empty repository error ( #10248 )
...
* Fix queue pop error and stat empty repository error
* Fix error
2020-02-12 18:12:27 +08:00
Lunny Xiao
2664979048
Add feishu webhook support ( #10229 )
...
Add feishu webhook support
2020-02-12 08:48:28 +00:00
zeripath
ec46e50b7e
Stop hanging issue indexer initialisation from preventing shutdown ( #10243 )
...
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-02-12 00:21:20 +01:00
John Olheiser
868bdd06f7
Add Octicon SVG spritemap ( #10107 )
...
* Add octicon SVG sprite
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Static prefix
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* SVG for all repo icons
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* make vendor
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Swap out octicons
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move octicons to top of less imports
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix JS
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Definitely not a search/replace
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Missed regex
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move to more generic calls and webpack
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* make svg -> make webpack
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Remove svg-sprite
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Update tests
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Missed a test
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Remove svg from makefile
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Suggestions
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Attempt to fix test
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Update tests
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Revert timetracking test
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Swap .octicon for .svg in less
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add aria-hidden
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Replace mega-octicon
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix webpack globbing on Windows
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Revert
Co-Authored-By: silverwind <me@silverwind.io >
* Fix octions from upstream
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix Vue and missed JS function
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add JS helper and PWA
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Preload SVG
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: techknowlogick <matti@mdranta.net >
2020-02-11 12:02:41 -05:00
Lauris BH
20e11119c4
Language statistics bar for repositories ( #8037 )
...
* Implementation for calculating language statistics
Impement saving code language statistics to database
Implement rendering langauge stats
Add primary laguage to show in repository list
Implement repository stats indexer queue
Add indexer test
Refactor to use queue module
* Do not timeout for queues
2020-02-11 11:34:17 +02:00
zeripath
09f79601ac
Restore graceful restart on SIGHUP ( #10224 )
...
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-02-11 13:29:45 +08:00
Lauris BH
69c7a85fee
Fix commit between two commits calculation if there is only last commit ( #10225 )
2020-02-11 01:04:43 +02:00
6543
d18573ddfc
[API] Fix inconsistent label color format ( #10129 )
...
* update and use labelColorPattern
* add TestCases
* fix lint
* # optional for templates
* fix typo
* some more
* fix lint of **master**
2020-02-09 14:33:03 +00:00
Lars Lehtonen
dbd5af16c1
modules/log: remove noop written variables ( #10182 )
...
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-02-07 21:35:30 +01:00
zeripath
b07c20c298
Prevent double waitgroup decrement ( #10170 )
...
* Prevent double waitgroup decrement
2020-02-07 09:08:09 +00:00
6543
994ca82496
[API] expose RepoOwner on Issue responce ( #10126 )
...
* add RepoOwner on issue api responce
* CI.restart()
2020-02-04 00:05:17 -05:00
Lauris BH
29881b8f58
Show download count info in release list ( #10124 )
...
* Show download count info in release list
* Use go-humanize
2020-02-03 21:50:37 +02:00
Lunny Xiao
7d13aada9e
Move PushUpdateAddDeleteTags to repository module from models ( #10106 )
...
* Move PushUpdateAddDeleteTags to repository module from models
* Fix deadlock on sqlite
2020-02-03 09:47:04 +01:00
zeripath
e3ef3c5216
Add Unique Queue infrastructure and move TestPullRequests to this ( #9856 )
...
* Upgrade levelqueue to version 0.2.0
This adds functionality for Unique Queues
* Add UniqueQueue interface and functions to create them
* Add UniqueQueue implementations
* Move TestPullRequests over to use UniqueQueue
* Reduce code duplication
* Add bytefifos
* Ensure invalid types are logged
* Fix close race in PersistableChannelQueue Shutdown
2020-02-02 23:19:58 +00:00
Lunny Xiao
520346eb0e
Improve push update options ( #10105 )
...
* Improve push update options
* fix test
* More refactor and fix lint
* fix lint
* Fix lint
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-02-02 15:27:34 -05:00
guillep2k
c6411fce18
Add warning when using relative path to app.ini ( #10104 )
...
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-02-02 18:20:20 +02:00
guillep2k
e46ebc5383
Implement "embedded" command to extract static resources ( #9982 )
...
* draft
* Implement extract command
* Fix nits and force args on extract
* Add !bindata stub, support Windows, fmt
* fix vendored flag
* Remove leading slash for matching
* Add docs
* Fix typos
* Add embedded view command
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2020-02-02 10:17:44 +08:00