Lunny Xiao
ea41740d36
Move some files into models' sub packages ( #20262 )
...
* Move some files into models' sub packages
* Move functions
* merge main branch
* Fix check
* fix check
* Fix some tests
* Fix lint
* Fix lint
* Revert lint changes
* Fix error comments
* Fix lint
Co-authored-by: 6543 <6543@obermui.de >
2022-08-25 10:31:57 +08:00
Balki
817ad0fd11
Fix panic when an invalid oauth2 name is passed ( #20820 )
2022-08-17 14:25:28 -04:00
Lunny Xiao
91eb009fe2
Refactor AssertExistsAndLoadBean to use generics ( #20797 )
...
* Refactor AssertExistsAndLoadBean to use generics
* Fix tests
Co-authored-by: zeripath <art27@cantab.net >
2022-08-16 10:22:25 +08:00
zeripath
13510b4477
WebAuthn CredentialID field needs to be increased in size ( #20530 )
...
WebAuthn have updated their specification to set the maximum size of the
CredentialID to 1023 bytes. This is somewhat larger than our current
size and therefore we need to migrate.
The PR changes the struct to add CredentialIDBytes and migrates the CredentialID string
to the bytes field before another migration drops the old CredentialID field. Another migration
renames this field back.
Fix #20457
Signed-off-by: Andrew Thornton <art27@cantab.net >
2022-07-30 15:25:26 +02:00
Wim
f481b601d6
Add more linters to improve code readability ( #19989 )
...
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003 ) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005 )
2022-06-20 12:02:49 +02:00
Lunny Xiao
8d11f1ee65
Move almost all functions' parameter db.Engine to context.Context ( #19748 )
...
* Move almost all functions' parameter db.Engine to context.Context
* remove some unnecessary wrap functions
2022-05-20 22:08:52 +08:00
6543
dfd9473d30
Delete user related oauth stuff on user deletion too ( #19677 )
...
* delete user related oauth stuff on user deletion too
* extend doctor check-db-consistency
2022-05-11 13:16:35 +02:00
Lunny Xiao
06d8c2f14f
Fix some slice problems (incorrect slice length) ( #19592 )
2022-05-03 17:04:23 +08:00
Lunny Xiao
6b6e9e3a68
Use a struct as test options ( #19393 )
...
* Use a struct as test options
* Fix name
* Fix test
2022-04-14 21:58:21 +08:00
zeripath
a411b6d863
Attempt to fix the webauthn migration again - part 3 ( #18770 )
...
v208.go is seriously broken as it misses an ID() check. We need to no-op and remigrate all of the u2f keys.
See #18756
Signed-off-by: Andrew Thornton <art27@cantab.net >
2022-02-16 21:03:58 +00:00
Gusted
72de6a47b7
Use CryptoRandomBytes instead of CryptoRandomString ( #18439 )
...
- Switch to use `CryptoRandomBytes` instead of `CryptoRandomString`, OAuth's secrets are copied pasted and don't need to avoid dubious characters etc.
- `CryptoRandomBytes` gives  `CryptoRandomString` gives  possible states.
- Add a prefix, such that code scanners can easily grep these in source code.
- 32 Bytes + prefix
2022-02-04 18:03:15 +01:00
wxiaoguang
40baaefdb6
Use base32 for 2FA scratch token ( #18384 )
...
* Use base32 for 2FA scratch token
* rename Secure* to Crypto*, add comments
2022-01-26 12:10:10 +08:00
6543
e0a2bd79c9
format with gofumpt ( #18184 )
...
* gofumpt -w -l .
* gofumpt -w -l -extra .
* Add linter
* manual fix
* change make fmt
2022-01-20 18:46:10 +01:00
zeripath
cca3abf0e8
Webauthn nits ( #18284 )
...
This contains some additional fixes and small nits related to #17957
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2022-01-15 17:52:56 +01:00
Lunny Xiao
dde6775cd7
Support webauthn ( #17957 )
...
Migrate from U2F to Webauthn
Co-authored-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2022-01-14 16:03:31 +01:00
Lunny Xiao
4aeb0c73b6
Refactor auth package ( #17962 )
2022-01-02 21:12:35 +08:00
