Wim
f481b601d6
Add more linters to improve code readability ( #19989 )
...
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003 ) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005 )
2022-06-20 12:02:49 +02:00
zeripath
3db240576b
Update Goldmark to Goldmark 1.4.4 ( #18420 )
...
* Update Goldmark to Goldmark 1.4.4
* nolint the deprecation
Signed-off-by: Andrew Thornton <art27@cantab.net >
2022-01-29 21:17:21 +08:00
6543
e0a2bd79c9
format with gofumpt ( #18184 )
...
* gofumpt -w -l .
* gofumpt -w -l -extra .
* Add linter
* manual fix
* change make fmt
2022-01-20 18:46:10 +01:00
Ben Niemann
42e92f215f
Remove unneeded debug messages to stdout. ( #18298 )
...
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2022-01-16 23:42:06 +08:00
Lunny Xiao
cde9b560fa
Fix some lints ( #17337 )
...
Fix some linting problems.
2021-10-17 20:47:12 +01:00
6543
fb4c16d24d
Code Formats, Nits & Unused Func/Var deletions ( #15286 )
...
* _ to unused func options
* rm useless brakets
* rm trifial non used models functions
* rm dead code
* rm dead global vars
* fix routers/api/v1/repo/issue.go
* dont overload import module
2021-04-09 09:40:34 +02:00
zeripath
890a1b74b5
Don't replace underscores in auto-generated IDs in goldmark ( #12805 )
...
Fix #12196
Signed-off-by: Andrew Thornton <art27@cantab.net >
2020-09-12 12:00:48 -04:00
6543
1baa253947
Fix potential bugs ( #10513 )
...
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
2020-02-27 20:10:27 -03:00
zeripath
903a06b594
Change markdown rendering from blackfriday to goldmark ( #9533 )
...
* Move to goldmark
Markdown rendering moved from blackfriday to the goldmark.
Multiple subtle changes required to the goldmark extensions to keep
current rendering and defaults.
Can go further with goldmark linkify and have this work within markdown
rendering making the link processor unnecessary.
Need to think about how to go about allowing extensions - at present it
seems that these would be hard to do without recompilation.
* linter fixes
Co-authored-by: Lauris BH <lauris@nix.lv >
2019-12-31 03:53:28 +02:00
